xiaoxiang781216 commented on code in PR #14687: URL: https://github.com/apache/nuttx/pull/14687#discussion_r1832864569
########## boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h: ########## @@ -0,0 +1,286 @@ +/**************************************************************************** + * boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ +#pragma once + +#define SP(X) ((X) << 12) +#define SU(X) ((X) << 8) +#define NP(X) ((X) << 4) +#define NU(X) ((X) << 0) +#define LK BIT(31) +#define RWX 7 +#define RW 6 +#define RX 5 +#define R 4 +#define X 1 +#define TEE_SHM_SIZE 0x0 + +/* GLBAC7 is used for TRDC only, any setting to GLBAC7 will be ignored + * GLBAC6 is used for fused modules, any setting to GLBAC6 will be ignored + */ + +/* aonmix */ + +struct trdc_glbac_config trdc_a_mbc_glbac[] = +{ + { 0, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC0 */ + { 1, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC1 */ + { 1, 1, SP(RW) | SU(R) | NP(RW) | NU(R) }, + { 1, 2, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) }, +}; + +struct trdc_mbc_config trdc_a_mbc[] = Review Comment: add g_ prefix, should we move all global variables to c file ########## boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h: ########## @@ -0,0 +1,286 @@ +/**************************************************************************** + * boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ +#pragma once + +#define SP(X) ((X) << 12) +#define SU(X) ((X) << 8) +#define NP(X) ((X) << 4) +#define NU(X) ((X) << 0) +#define LK BIT(31) +#define RWX 7 +#define RW 6 +#define RX 5 +#define R 4 +#define X 1 +#define TEE_SHM_SIZE 0x0 + +/* GLBAC7 is used for TRDC only, any setting to GLBAC7 will be ignored + * GLBAC6 is used for fused modules, any setting to GLBAC6 will be ignored + */ + +/* aonmix */ + +struct trdc_glbac_config trdc_a_mbc_glbac[] = Review Comment: where we use these new global variables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
