nuttxpr commented on PR #2829: URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462231910
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description lacks crucial information. Here's what's missing and why it's important: * **Insufficient Summary:** "write returns..." is too vague. What *specifically* was changed in the code? Which function(s) were modified? What was the previous, incorrect behavior? The reference to the commit hash is helpful but insufficient; explain the change in human-readable terms. A link to the relevant NuttX Issue is missing. * **Incomplete Impact Assessment:** While it mentions fixing a CI issue, it doesn't fully address all the impact points. Consider: * **Impact on user:** Does this change the behavior of applications using `write`? Even if the change aligns with POSIX, it's still a change that might affect user code. * **Impact on hardware:** Unclear. While tested on a SAME7 board, does this change affect other architectures? Explicitly state "NO" or provide details if "YES." Similarly for drivers. * **Impact on documentation:** Does this change require documentation updates? * **Impact on compatibility:** Explicitly address backward compatibility. Does this change break existing NuttX applications? * **Impact on security:** Consider if this change has any security ramifications. Even if the answer is "NO," it should be explicitly stated. * **Inadequate Testing:** "pipe was executed..." is far too vague. What were the specific test cases? What were the *expected* outputs before and after the change? The provided log sections are empty. Provide concrete examples of commands and their outputs, demonstrating both the previous broken behavior and the corrected behavior. Include details about the build host used for testing. **In short:** The PR description needs to be significantly more detailed to meet the NuttX requirements. It must clearly articulate the change, its rationale, its impact across different aspects of the system, and provide verifiable testing evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
