nuttxpr commented on PR #14696: URL: https://github.com/apache/nuttx/pull/14696#issuecomment-2464080582
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. While it attempts to address the summary section, it lacks crucial information: * **Missing Explanation of Necessity:** It states *what* isn't working, but not *why* the change is necessary. What problem does this solve? Why are `bin` and `kbin` not being cleaned? Why should they be created during context construction? * **Missing Technical Details:** It mentions *what* is being changed (creation of `bin`, `kbin` during context construction) but not *how*. What code is being modified? What is the context construction process? * **Missing Issue References:** Are there any related issues in the NuttX or NuttX Apps repositories? * **Impact Section Too Brief:** Even if there is no user, build, hardware, documentation, security, or compatibility impact, the PR submitter should explicitly state "NO" for each item and briefly justify why (e.g., "Impact on user: NO - This is an internal change to the build system"). "None" is too ambiguous. * **Testing Section Inadequate:** "None" is unacceptable. The PR description *must* include testing information. Even if the change is small, there should be some evidence that it works as intended. What was tested? What were the results? Empty log sections are not helpful. The submitter needs to significantly revise the PR description to provide the missing details and demonstrate that the change has been properly tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
