nuttxpr commented on PR #2833: URL: https://github.com/apache/nuttx-apps/pull/2833#issuecomment-2464185523
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR summary lacks crucial details. While it states *what* changed, it doesn't explain *why* retrying on a signal interrupt is necessary for `nsh_read()`, specifically in the context of pipes and child processes. The impact section is also too brief, simply restating the affected file. It needs to address the impact questions listed in the requirements. Finally, relying solely on GitHub CI for testing is insufficient. Local testing details (host and target) and example logs before/after the change are required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
