nuttxpr commented on PR #14739: URL: https://github.com/apache/nuttx/pull/14739#issuecomment-2469881193
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. The provided information is essentially placeholder text copied from the template. It lacks critical details about the actual changes being made. Specifically, the following sections are incomplete: * **Summary:** Completely missing the *why*, *what*, and *how* of the change. The two lines of code provide no context. * **Impact:** All impact assessments are left as placeholders. Without knowing the change, impact cannot be assessed. * **Testing:** Completely missing build host, target details, and before/after testing logs. The current "testing logs" are just function calls and not actual logs. The submitter needs to fill out these sections completely with specific details about their change before the PR can be considered. Just including the function calls `sys_call2(SYS_switch_context, ...)` and `sys_call1(SYS_restore_context, ...)` doesn't explain anything about the *purpose* or *effect* of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
