pussuw commented on code in PR #14739:
URL: https://github.com/apache/nuttx/pull/14739#discussion_r1839636663
##########
arch/arm64/include/irq.h:
##########
@@ -407,14 +407,16 @@ static inline void up_irq_restore(irqstate_t flags)
#define up_update_task(t) modify_sysreg(t, ~1ul, tpidr_el1)
#define up_interrupt_context() (read_sysreg(tpidr_el1) & 1)
-#define up_switch_context(tcb, rtcb) \
- do { \
- if (!up_interrupt_context()) \
- { \
- sys_call2(SYS_switch_context, (uintptr_t)&rtcb->xcp.regs, \
- (uintptr_t)tcb->xcp.regs); \
- } \
- } while (0)
+#define up_switch_context(tcb, rtcb) \
+ do \
+ { \
+ if (!up_interrupt_context()) \
+ { \
+ sys_call2(SYS_switch_context, (uintptr_t)rtcb, \
+ (uintptr_t)tcb); \
Review Comment:
I think the wrapping here is unnecessary, it should fit to 78 columns on one
line?
`sys_call2(SYS_switch_context, (uintptr_t)rtcb, (uintptr_t)tcb); `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
