JianyuWang0623 opened a new pull request, #2850:
URL: https://github.com/apache/nuttx-apps/pull/2850

   ## Summary
   Fix variable arguments concat error of `nsh_execute()`  
   #### Without this patch
   ```
   nsh> set time 5
   nsh> echo $time
   5
   nsh> sleep $time &
   sh [5:100]
   nsh> nsh: sleep: missing required argument(s)
   ```
   #### With this patch
   ```
     nsh> set time 5
     nsh> echo $time
     5
     nsh> sleep $time &
     sh [4:100]
     nsh> ps
       PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK            
STACK COMMAND
         0     0   0 FIFO     Kthread   - Ready              0000000000000000 
0069616 Idle_Task
         1     0 224 FIFO     Kthread   - Waiting  Signal    0000000000000000 
0067536 loop_task
         2     0 224 FIFO     Kthread   - Waiting  Semaphore 0000000000000000 
0067504 hpwork 0x501760e0 0x50176128
         3     3 100 FIFO     Task      - Running            0000000000000000 
0067536 nsh_main
         4     4 100 FIFO     Task      - Waiting  Signal    0000000000000000 
0067520 sh -c sleep
   ```
   **Reported by [email protected], owned by @jasonbu,** updated by 
@JianyuWang0623
   ## Impact
   nshlib/nsh_parse:nsh_execute()
   
   ## Testing
   1. Selftest as above/commit message
   2. NuttX CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to