hujun260 commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1841466655
########## sched/irq/irq_csection.c: ########## @@ -75,6 +75,18 @@ volatile uint8_t g_cpu_nestcount[CONFIG_SMP_NCPUS]; * Private Functions ****************************************************************************/ +static bool csection_degraded(void) Review Comment: > any logic, including DIAGASSERT, you mean? why? This line indicate that enter_critical_section should not be used early in the boot https://github.com/apache/nuttx/blob/d4f6cc229d55a0c252ba6a821b9f1789e53d4bbc/sched/irq/irq_csection.c#L206 You should add checks at the place of invocation to ensure that the assert will not be triggered, rather than modifying the enter_critical_section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
