crafcat7 commented on code in PR #14755:
URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841618746
##########
sched/semaphore/sem_holder.c:
##########
@@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem)
{
/* Check our assumptions */
- DEBUGASSERT(atomic_load(NXSEM_COUNT(sem)) <= 0);
+ DEBUGASSERT((int16_t)atomic_load(NXSEM_COUNT(sem)) <= 0);
Review Comment:
> @crafcat7 please fix this ASAP.
Later we can consider whether there is a better way to reorganize
arch_atomic & nuttx/stdatomic.c so that they can directly go to the atomic
processing of the corresponding type, in other words, it can return the same
result type as the input type parameter.
This work should take some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
