nuttxpr commented on PR #14801: URL: https://github.com/apache/nuttx/pull/14801#issuecomment-2477847770
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description lacks crucial details required by the NuttX guidelines. Here's why and what's missing: * **Insufficient Summary:** While the summary states *what* changed, it doesn't adequately explain *how* it works. It mentions circular dependencies and incomplete handling, but lacks specifics. For example: * How was the `spinlock_t` incompletely handled before? Give a concrete example. * Precisely what went into `spinlock_type.h` and what stayed in `spinlock.h`? * What code now includes `spinlock_type.h` that previously included `spinlock.h`? * **Incomplete Impact Assessment:** "spinlock" is not a sufficient impact description. Address *all* the impact points individually. At the very least, explicitly state "NO" for those that aren't applicable. For example: * **Impact on user:** Does the user need to change any code due to this split? * **Impact on build:** Does the build system need any modifications? * **Impact on hardware:** Are any architectures or boards affected? * **Impact on documentation:** Does this change necessitate documentation updates? * ...and so on for all the impact categories. * **Insufficient Testing:** "ci" is not adequate testing verification. Provide: * Specific build host details (OS, compiler version, etc.). * Specific target details (architecture, board, configuration). * Actual *before* and *after* logs demonstrating the problem and the fix. Simply stating that CI passed isn't enough; the reviewer needs to see the evidence. **In short, this PR description needs significantly more detail to meet NuttX requirements.** Focus on providing concrete information and evidence to support the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
