nuttxpr commented on PR #14802: URL: https://github.com/apache/nuttx/pull/14802#issuecomment-2477903124
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requirements, although it could be more thorough. While it addresses the summary points, it lacks detail in the Impact and Testing sections. Here's how it could be improved: **Impact:** While stating "fix warning" is a start, it doesn't fully address the impact. Consider adding: * **Impact on user:** NO (unless the warning caused user-visible issues, which is unlikely but should be mentioned if true). * **Impact on build:** NO (assuming the fix doesn't change the build process itself). * **Impact on hardware:** NO (assuming the fix is purely in software). * **Impact on documentation:** NO (unless documentation needs updating to reflect the change). * **Impact on security:** NO (unless the warning masked a potential security issue). * **Impact on compatibility:** NO (unless the change breaks compatibility with existing code or hardware). **Testing:** "ci-test, local sim:segger" is too brief. Provide more specific details: * **Build Host(s):** Specify your OS, CPU architecture, and compiler version used for testing. For example: `Linux x86_64, GCC 12.2.0`. * **Target(s):** Be more specific. Instead of "sim:segger", specify the simulator being used (e.g., `qemu-system-arm`). * **Testing logs:** The PR description says to include logs, but doesn't actually include any. Provide relevant snippets of logs demonstrating the warning before the change and its absence after the change. If the logs are extensive, consider linking to a CI run or external log file. By adding this extra detail, the PR will be much clearer and easier for reviewers to assess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
