nuttxpr commented on PR #14804: URL: https://github.com/apache/nuttx/pull/14804#issuecomment-2478018247
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it explains *why* the revert is happening, it lacks details on *what* functionality befe29801ff50494eada535906369f89eb4f8424 introduced in the first place. What part of the code did that commit modify? What was its intended purpose? This context is essential for reviewers. * **Impact:** This section is completely empty. Reverting a change can have significant impacts. The PR needs to address *all* the impact points, even if the answer is "NO". Specifically, it needs to detail the impact the *reverted* functionality had so reviewers can assess the consequences of removing it. For example, what features are being disabled/re-enabled? Are any build changes being undone? * **Testing:** While the target is mentioned, the build host information is missing. Also, "works as intended" is vague. What was the expected behavior before and after the revert? The provided logs should demonstrate the fix for the reported regressions (ideally, show the failing behavior before the revert and the working behavior after). **To make this PR compliant, the author should:** 1. **Expand the Summary:** Explain what functionality befe29801ff50494eada535906369f89eb4f8424 introduced and what parts of the code it affected. 2. **Complete the Impact section:** Address *all* impact points. Consider the impact of *removing* the functionality added by the reverted commit. 3. **Provide complete testing details:** Include the build host information (OS, CPU, compiler). Clarify the expected behavior and ensure the logs demonstrate the resolution of the mentioned regressions. By addressing these points, the PR will be more complete, easier to review, and better aligned with the NuttX contribution guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
