nuttxpr commented on PR #14806: URL: https://github.com/apache/nuttx/pull/14806#issuecomment-2478161719
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. The summary is insufficient. It vaguely mentions moving code to userspace but doesn't explain *why* this is necessary beyond no longer needing `enter_critical_section`. It also mentions reverting a commit which should be explained further in the summary. What feature or functionality does this revert affect? The "Impact" section is severely lacking. It only mentions `pthread_barrierwait` which doesn't explain the impact. All other impact categories need to be addressed with NO/YES and a description if YES. The "Testing" section is also inadequate. Simply stating "ci" is not sufficient. It needs to specify the build host details (OS, CPU, compiler) and the target architecture and board configuration. Crucially, it is missing the "Testing logs before change" and "Testing logs after change" which are *required* to demonstrate the effect of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
