acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483303781
> > > > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. > > > > > > > > > Update, you can learn the concept and spec from: https://docs.kernel.org/6.1/driver-api/tty/n_gsm.html > > > > > > Thank you Xiang! What is the purpose of this external too to NuttX, since NuttX doesn't have CMUX support yet? > > I think this is the question I and everybody that find this program at nuttx/tools/ will ask. This application is for Linux, not for NuttX, correct? > > Yes, that's why this tool is put into nuttx/tools, not apps/. > > > @xiaoxiang781216 I think /me and @hartmannathan are asking some question: why to include a program that is supported only for Linux into NuttX? > > Because you need this tool to change host serial port into mux mode. > Why? Are you using the modem with SIM? Normally the CMUX will work integrated with PPP and the user should issue a command (or an IOCTL) to setup the CMUX (multiplexed) ports. > > The documentation you provided is for Linux, please consider including a Documentation/ to explain the goal and purpose to have a Linux host CMUX GSM > > @Gary-Hobson will provide a NuttX serial driver which implement CMUX protocol. > Great! Kudos @Gary-Hobson ! > > instead of adding CMUX support on NuttX and adding this cmux tool at nuttx-apps > > This tool doesn't need for NuttX since NuttX CMUX driver auto switch to mux mode by config, not through ioctl dynamically. > Hmm, I think having IOCTL support could be useful in case where we want to enter / leave CMUX during the PPP execution. > > > > @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? > > > @xiaoxiang781216 there is an issue already opened asking for CMUX support on NuttX: #7153 > > Yes, after @Gary-Hobson upstream MUX serial driver, #7153 could be closed as complete. > > > > Yes, it will come in the next patch. > > > > > > But in this case the cmux application should be inside nuttx-apps, instead of nuttx/tools/, right? > > No, NuttX mux driver could work automatically without the setup like Linux, that's why this tool put into nuttx/tools/ not apps/. Hmm, by automatically you mean statically, right? It should be use some board config to enter in this CMUX mode, correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
