xiaoxiang781216 commented on code in PR #2859:
URL: https://github.com/apache/nuttx-apps/pull/2859#discussion_r1846963527
##########
system/gcov/Kconfig:
##########
@@ -5,7 +5,7 @@
config SYSTEM_GCOV
tristate "gcov tool"
- depends on SCHED_GCOV
+ depends on !COVERAGE_NONE
Review Comment:
does gcov work with clang coverage?
##########
system/gcov/gcov.c:
##########
@@ -69,6 +69,70 @@ static void gcov_dump(FAR const char * path, FAR const char
*strip)
__gcov_dump();
}
+/****************************************************************************
+ * Name: stdout_dump
+ ****************************************************************************/
+
+static void stdout_dump(FAR const void *buffer, size_t size,
+ FAR void *arg)
+{
+ FAR const char *name = *((FAR const char **)arg);
+ struct lib_stdoutstream_s stdoutstream;
+ struct lib_hexdumpstream_s hexstream;
+ uint16_t checksum = 0;
+ int i;
+
+ if (size == 0)
+ {
+ return;
+ }
+
+ for (i = 0; i < size; i++)
+ {
+ checksum += ((uint8_t *)buffer)[i];
Review Comment:
```suggestion
checksum += ((FAR const uint8_t *)buffer)[i];
```
##########
system/gcov/gcov.c:
##########
@@ -69,6 +69,70 @@ static void gcov_dump(FAR const char * path, FAR const char
*strip)
__gcov_dump();
Review Comment:
why mini profile doesn't implement __gcov_dump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
