FASTSHIFT commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845816244
##########
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##########
@@ -545,10 +569,59 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd_base_updatearea(struct fb_vtable_s *vtable,
const struct fb_area_s *area)
{
+ if (area->w == 0 || area->h == 0)
+ {
+ return 0;
+ }
+
+ if (area->x + area->w > ESP32S3_LCD_HRES_VIRTUAL ||
+ area->y + area->h > ESP32S3_LCD_VRES_VIRTUAL)
+ {
+ gerr("ERROR: updatearea area is out of bounds\n");
Review Comment:
print `area` info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
