nuttxpr commented on PR #14920: URL: https://github.com/apache/nuttx/pull/14920#issuecomment-2496528597
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Specifically: * **Summary:** Needs more detail. *What* functional part of `nuttxgdb` changed? *How* does integrating `debugpy` work within `nuttxgdb`? What exact code changes were made? A link to a related NuttX issue is highly recommended. * **Impact:** Simply stating "No" is insufficient. Address *each* impact point individually. Even if there's no impact, explicitly state "NO" followed by a brief justification (e.g., "Impact on build: NO - No changes to the build system."). This PR likely *does* have an impact on the build (adding a dependency). * **Testing:** "Tested locally" is too vague. Specify the Build Host OS, CPU, compiler, and Target architecture and board configuration used for testing. Provide *actual* testing logs before and after the change, demonstrating the functionality and the improvement. Simply providing instructions on how to use the feature is not sufficient testing information. The PR needs significant revision to meet the NuttX requirements before it can be considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
