nuttxpr commented on PR #14927: URL: https://github.com/apache/nuttx/pull/14927#issuecomment-2497401720
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR summary lacks crucial information. While it mentions the spelling changes, it doesn't explain *where* these changes occur (what functional part of the code). It also lacks context: *why* were these typos present? Were they in comments, variable names, function names, etc.? This context helps reviewers understand the scope and potential ramifications of even seemingly trivial changes. The "Impact" section being simply "N/A" is insufficient. At minimum, it should explicitly state "NO" for each impact category to indicate that the author considered those aspects. The "Testing" section is also inadequate. "ci-check" doesn't provide any actual testing results. The template specifically requests "Testing logs before change" and "Testing logs after change". Even for a simple spelling fix, demonstrating that the code still compiles and (ideally) functions as expected is good practice. Information on the build host and target is also missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
