nuttxpr commented on PR #14938: URL: https://github.com/apache/nuttx/pull/14938#issuecomment-2499260441
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does **not** meet the NuttX requirements. The provided information is insufficient and indicates a build error. Here's why: * **Summary:** The summary describes a build error, not the intended change. It needs to explain *why* the code was changed (what bug was fixed, what feature was added) and *how* it addresses the issue. Simply pasting compiler errors isn't sufficient. * **Impact:** Claiming "none" is unlikely. Even a bug fix has an impact (fixes the bug!). This section needs to be filled out thoughtfully. At minimum, the corrected bug should be described. * **Testing:** "ci" is insufficient. The requirements ask for specific host and target details, as well as logs demonstrating the issue before the change and the successful operation after the change. Just saying "ci" doesn't provide any evidence that the change works as intended. If the build is failing, there *are no* "after" logs. This PR needs substantial revision before it can be considered. The author needs to: 1. **Fix the build error:** Address the `-Werror=int-conversion` error. It appears they are passing the spinlock value itself instead of a pointer to the spinlock. 2. **Rewrite the summary:** Explain the intended change, not just the error message. 3. **Complete the Impact section:** Describe the impact of the change, even if minimal. 4. **Provide proper testing information:** Detail the build host and target environments and provide *actual* logs demonstrating the issue before the change and the corrected behavior after the change. If the build is broken, they should provide logs showing the original failure and then logs showing the successful build and execution after the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
