nuttxpr commented on PR #14942: URL: https://github.com/apache/nuttx/pull/14942#issuecomment-2499369060
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it mentions fixing a compile error and referencing a prior PR, it's insufficient. It needs to explain *what* compile error was fixed, *what* functional part of the MCPWM driver was changed, and *how* the change fixes the error. * **Impact:** Simply stating "N/A" is unacceptable. Each impact item needs to be explicitly addressed with either "NO" or "YES" followed by a description if "YES." Even if there's no user-facing change, for example, the submitter should state "Impact on user: NO" for clarity. The fix likely impacts the build (at least it should fix a compile error), so that needs to be detailed. It might also impact hardware if the driver behavior changes. * **Testing:** While "ci-check" suggests CI testing was done, it's not sufficient. The requirements clearly ask for testing logs *before* and *after* the change. These logs demonstrate the problem being fixed and the successful resolution. The details of the build host and target are also missing. In short, the PR needs more detail and explicit answers to the requirements checklist to be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
