nuttxpr commented on PR #14954: URL: https://github.com/apache/nuttx/pull/14954#issuecomment-2500559075
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description lacks crucial information required by the NuttX guidelines. Here's why: * **Insufficient Summary:** While it mentions the change (`up_cpu_index` to `this_cpu`), it doesn't clearly explain *why* this change is necessary. What problem does it solve? What are the benefits of using `this_cpu`? It also doesn't explain *how* the change works beyond a very high-level description. * **Incomplete Impact Assessment:** Simply stating "sched" isn't enough. It needs YES/NO answers for *all* impact categories, with explanations where applicable. For example: * **Impact on user:** Likely NO, but needs confirmation. * **Impact on build:** Possibly NO, but needs explicit confirmation. * **Impact on hardware:** This is the most crucial part! The summary mentions AMP, implying a hardware impact. This needs a detailed explanation of which architectures/boards are affected. * **Impact on documentation:** Does this change require documentation updates? * **Impact on security, compatibility:** These need explicit NO/YES answers with justification. * **Inadequate Testing:** "ci ostest" is not sufficient. It needs: * Specific build host details (OS, CPU, compiler versions). * Specific target details (architecture, board, configuration). * **Actual testing logs** before *and* after the change, demonstrating the issue and the fix. Empty code blocks are unacceptable. The submitter needs to significantly revise this PR description to meet NuttX requirements before it can be properly reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
