xiaoxiang781216 commented on code in PR #14963:
URL: https://github.com/apache/nuttx/pull/14963#discussion_r1861395177
##########
arch/Kconfig:
##########
@@ -489,6 +489,10 @@ config ARCH_HAVE_TESTSET
bool
default n
+config ARCH_HAVE_CUSTOM_TESTSET
+ bool
+ default n
Review Comment:
let's select ARCH_HAVE_TESTSET
##########
sched/Kconfig:
##########
@@ -365,7 +365,7 @@ config SMP
bool "Symmetric Multi-Processing (SMP)"
default n
depends on ARCH_HAVE_MULTICPU
- depends on ARCH_HAVE_TESTSET
+ depends on ARCH_HAVE_TESTSET || ARCH_HAVE_CUSTOM_TESTSET
Review Comment:
revert
##########
include/nuttx/spinlock.h:
##########
@@ -176,7 +176,7 @@ extern volatile uint8_t g_irq_spin_count[CONFIG_SMP_NCPUS];
*
****************************************************************************/
-#if defined(CONFIG_ARCH_HAVE_TESTSET)
+#if defined(CONFIG_ARCH_HAVE_TESTSET) ||
defined(CONFIG_ARCH_HAVE_CUSTOM_TESTSET)
Review Comment:
```suggestion
#ifndef CONFIG_ARCH_HAVE_TESTSET
static inline spinlock_t up_testset(FAR volatile spinlock_t *lock)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
