nuttxpr commented on PR #14990: URL: https://github.com/apache/nuttx/pull/14990#issuecomment-2507498294
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR likely *does not* meet the NuttX requirements based on the information provided. While it mentions a documentation update, it lacks crucial details. Here's why: * **Insufficient Summary:** "mps3an547 doc update" is too vague. What specifically was updated in the documentation? What problem did the update address? What part of the mps3an547 is documented? * **Missing Impact Details:** While "noting" suggests no impact, it's best to explicitly state "NO" for each impact category. Even for documentation changes, describe *what* documentation changed. * **Inadequate Testing:** "use latest qemu" isn't sufficient. What tests were run? Provide *specific* commands used and the relevant *output* demonstrating the documentation's correctness (e.g., before/after screenshots if it's a visual change, or commands that now work due to the improved docs). The "Testing logs before change" and "Testing logs after change" sections are empty, which is a major red flag. **To make this PR acceptable, the author needs to:** 1. **Expand the Summary:** Explain the reason for the documentation update, the specific part of the mps3an547 being documented, and the nature of the changes made to the documentation. 2. **Clarify Impact:** Explicitly state "NO" for all impact categories where applicable. For the "Impact on documentation" section, specify which documentation files were changed and how. 3. **Provide Detailed Testing Information:** Describe the specific tests conducted on QEMU. Include the QEMU version, the NuttX configuration used, the commands executed to verify the documentation, and the output of those commands both before and after the change. Screenshots can be helpful for visual changes. Even if the change is just documentation, demonstrating its practical value through example commands and their outputs makes the PR much stronger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
