nuttxpr commented on PR #15030: URL: https://github.com/apache/nuttx/pull/15030#issuecomment-2513893063
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and identifies the impacted architecture, it lacks crucial information. Here's what's missing: * **Detailed Summary:** The summary needs to explain *what* the regression was, *what functional part of the code* was changed to fix it, and *how* the fix works. Simply referencing another PR isn't sufficient. * **Complete Impact Assessment:** While "riscv" is mentioned, the impact assessment needs to be more thorough. Even if the answer is "NO" for most categories, it should be explicitly stated (e.g., "Impact on user: NO"). It's unclear if there are build, hardware, documentation, security, or compatibility implications. * **Comprehensive Testing Information:** The testing section is inadequate. It needs to specify the build host details (OS, CPU, compiler) and provide *complete* target information (architecture, board, configuration). Most importantly, the "Testing logs before change" and "Testing logs after change" sections are empty. Actual logs demonstrating the issue and the fix are required. The PR needs to be expanded to address these missing points before it can be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
