xiaoxiang781216 commented on code in PR #15033:
URL: https://github.com/apache/nuttx/pull/15033#discussion_r1867679739
##########
arch/arm/src/rp23xx/rp23xx_usbdev.c:
##########
@@ -1709,12 +1713,9 @@ static int rp23xx_epcancel(struct usbdev_ep_s *ep,
static int rp23xx_epstall_exec(struct usbdev_ep_s *ep)
{
struct rp23xx_ep_s *privep = (struct rp23xx_ep_s *)ep;
- irqstate_t flags;
usbtrace(TRACE_EPSTALL, privep->epphy);
- flags = spin_lock_irqsave(NULL);
Review Comment:
why not keep the lock here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
