nuttxpr commented on PR #15041: URL: https://github.com/apache/nuttx/pull/15041#issuecomment-2516574264
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides *some* information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** The summary is too vague. It needs to explain *why* this symbol information is being added. What problem does it solve? What functionality does it enable? How does it work? It also needs to link related issues if applicable. Saying the license is the same as another file doesn't explain the *purpose* of the change. * **Impact:** While stating "None" is concise, it's unlikely there is *zero* impact. Think carefully. Does this change enable a new driver or feature? Even if the user doesn't directly interact with it, there might be indirect impacts. Be explicit. If there truly is no impact on any of the listed categories, explicitly state "NO" for each one for clarity. * **Testing:** The testing section is insufficient. "Build only" isn't proper testing. What was the expected outcome of the build? Did it succeed? Show the relevant build output. Since this involves symbol information, were any tools used to verify the symbols are correct and usable? Provide concrete evidence that the change works as intended. Simply stating the target platform is not enough; show the actual build and test logs (even if they're short) before and after the change. In short, the PR needs to be much more descriptive and provide concrete evidence of testing and impact analysis. Assume the reviewer knows nothing about the context of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
