xiaoxiang781216 commented on code in PR #15048:
URL: https://github.com/apache/nuttx/pull/15048#discussion_r1869837047
##########
arch/arm/src/armv6-m/arm_doirq.c:
##########
@@ -57,15 +57,15 @@ void exception_direct(void)
uint32_t *arm_doirq(int irq, uint32_t *regs)
{
struct tcb_s **running_task = &g_running_tasks[this_cpu()];
- FAR struct tcb_s *tcb;
+ FAR struct tcb_s *tcb = *running_task;
Review Comment:
remove FAR
##########
arch/arm/src/armv6-m/arm_doirq.c:
##########
@@ -84,6 +84,12 @@ uint32_t *arm_doirq(int irq, uint32_t *regs)
irq_dispatch(irq, regs);
#endif
+ if (tcb->sigdeliver)
+ {
+ irqstate_t flags = enter_critical_section();
Review Comment:
why need critical section
##########
arch/arm/src/armv7-m/arm_schedulesigaction.c:
##########
@@ -81,14 +81,13 @@
void up_schedule_sigaction(struct tcb_s *tcb)
{
- sinfo("tcb=%p, rtcb=%p current_regs=%p\n", tcb, this_task(),
- this_task()->xcp.regs);
+ FAR struct tcb_s *rtcb = running_task();
Review Comment:
remove FAR
##########
arch/arm/src/armv8-m/arm_schedulesigaction.c:
##########
@@ -81,14 +81,13 @@
void up_schedule_sigaction(struct tcb_s *tcb)
{
- sinfo("tcb=%p, rtcb=%p current_regs=%p\n", tcb, this_task(),
- this_task()->xcp.regs);
+ FAR struct tcb_s *rtcb = running_task();
Review Comment:
remove FAR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
