nuttxpr commented on PR #15051: URL: https://github.com/apache/nuttx/pull/15051#issuecomment-2518529574
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change, it lacks crucial details. Here's what's missing: * **Summary:** Needs more detail. *Why* are these defconfigs necessary? What problem do they solve or what new functionality do they enable? What part of the code is changed (e.g., Kconfig files)? *How* do the changes work (what options are enabled in the defconfigs)? * **Impact:** Claiming "N/A" is almost never accurate. At a minimum, this adds new build configurations. Does this affect any existing functionality? Does it change the size of the build? Think carefully about all the impact categories and justify why they are N/A, or describe the actual impact. * **Testing:** This is insufficient. "Tested configs + applications" is vague. What applications? What tests were run? Provide *specific* commands used and the *actual output* (log snippets) before and after the change to demonstrate the fix or new functionality. Include details about the build host and target as requested. Just saying "it works" is not enough. The PR needs significant revision to meet the NuttX requirements. Providing the missing details will greatly improve the chances of the PR being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
