nuttxpr commented on PR #15066: URL: https://github.com/apache/nuttx/pull/15066#issuecomment-2521055773
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. While it touches on some aspects, it lacks crucial details. Here's a breakdown of what's missing: **Summary:** * **Insufficient Detail:** Saying "brings us a step closer to easy SBOM generation" is vague. *What* changes were made? What SPDX identifiers were added? Which files were modified? What tools are now expected to work better? Be specific. * **Missing Links:** If this relates to a specific effort to improve SBOM generation, link to related issues or discussions. **Impact:** * **Incomplete:** Simply saying "SBOM" isn't enough. Address *all* the impact points explicitly, even if the answer is "NO". For example: * **Is new feature added? Is existing feature changed?** (Likely YES - Specify what's new/changed regarding SBOM handling) * **Impact on user:** Will users need to do anything differently? Even if the answer is no, state it explicitly. * **Impact on build:** Does this add any dependencies? Change build times? * **Impact on hardware:** Likely NO, but state it explicitly. * **Impact on documentation:** If SPDX identifiers are now used, the documentation might need updates. * **Impact on security, compatibility:** Even if NO, state it explicitly. **Testing:** * **Insufficient:** "CI" isn't enough. Which CI systems? Which targets? Provide specific details about your local testing environment (OS, compiler, etc.) and the target hardware/simulator you tested on. * **Missing Logs:** You *must* include testing logs demonstrating the change's effect. Show output relevant to SBOM generation before and after your changes. Even a simple example demonstrating the improved functionality is essential. **In short, the PR description needs to be much more specific and address all the required points in the template. Provide concrete details about the changes, their impact, and clear evidence from testing that the changes work as intended.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
