nuttxpr commented on PR #15089: URL: https://github.com/apache/nuttx/pull/15089#issuecomment-2527483924
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details required for proper review. Here's a breakdown of what's missing: **Summary:** * **Insufficient detail:** "CPUs will acknowledge they have booted" is vague. *How* do they acknowledge? What mechanism is used? What changes were made to the code to implement this? * **Missing context:** What functional part of the bootloader is affected? * **No issue references:** Are there any related NuttX issues? **Impact:** * **Unclear and incomplete:** "MPFS bootloader CPU boot only" doesn't explain the impact. Does this mean *only* the MPFS bootloader is affected? Even then, how is it affected? The PR description needs to explicitly answer all the impact questions (user, build, hardware, documentation, security, compatibility) with "YES" or "NO" and provide descriptions where necessary. For example: * **Impact on user:** NO (This is a bootloader change, and users shouldn't interact directly with it) * **Impact on build:** YES (potentially, if any build system changes are necessary to support this feature. The description needs to explain these changes). * **Impact on hardware:** YES (This affects MPFS-based boards. Specify *which* boards.) * **Impact on documentation:** YES (likely needs updates to explain the new boot process). If documentation is included in the PR, mention it. * **Impact on security:** NO (If applicable. If there *are* security implications, they *must* be documented). * **Impact on compatibility:** Potentially YES. Does this change break compatibility with any existing boards or configurations? **Testing:** * **Insufficient information:** "MPFS bootloader" doesn't tell us *how* it was tested. * **Missing logs:** The "Testing logs before change" and "Testing logs after change" sections are empty. These are *crucial* for verifying the change works as intended. Include relevant log snippets showing the boot process before and after the change, demonstrating the acknowledgement mechanism. * **Missing host and target details:** Specify the build host OS, CPU architecture, compiler, and the target architecture and board/configuration used for testing. For example: * Build Host(s): Linux (Ubuntu 20.04), Intel x86_64, GCC 9.4.0 * Target(s): sim:qemu-rv In short, the PR description needs to be significantly more detailed and address all the points listed in the NuttX requirements. Provide specific information about the changes, their impact, and clear evidence from testing to demonstrate the functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
