nuttxpr commented on PR #15095: URL: https://github.com/apache/nuttx/pull/15095#issuecomment-2527993082
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's what's missing: * **Summary:** While it mentions *what* changed (removing extra spaces), it doesn't explain *why*. Was this for code style consistency? Was it causing a problem? Which files were affected? This section needs more context. Mentioning the specific files or directory affected would be very helpful. * **Impact:** While saying "none" is concise, it's likely not entirely accurate. Even whitespace changes *can* have an impact, especially if they affect code generation (though unlikely in this case). It's better to be explicit and say something like: * Impact on user: NO * Impact on build: NO (No changes to build process or dependencies) * Impact on hardware: NO * Impact on documentation: NO * Impact on security: NO * Impact on compatibility: NO * Anything else to consider: NO * **Testing:** "local nxstyle" is insufficient. This only confirms style compliance, not functionality. What part of NuttX was tested? Were any applications or drivers impacted by these changes? Even if the changes are purely cosmetic, some basic functional tests should be run and the results provided (even if they are identical before and after). Ideally, there would be *before* and *after* logs showing that the system functions as expected, or specific test cases demonstrating that the extra spaces were causing a problem (if that was the motivation for the change). Specify the host OS, target architecture, and board/configuration used for testing. In short, the PR needs to be more thorough in justifying the change, outlining potential impacts (even if they're negative), and providing concrete testing evidence beyond just style checking. While whitespace cleanup is important, the PR needs to demonstrate that it doesn't introduce any unintended consequences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
