nuttxpr commented on PR #15101: URL: https://github.com/apache/nuttx/pull/15101#issuecomment-2529673580
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does *not* meet the NuttX requirements. While it provides the required sections, it lacks crucial details. Specifically: * **Summary:** "Fix some typos" is insufficient. It needs to specify *which* typos were fixed and *where* they were located (e.g., "Fixes typos in the I2C driver documentation"). * **Impact:** While the impact *might* be none, it needs to explicitly address *all* impact categories (user, build, hardware, documentation, security, compatibility) with "NO" for each if truly none. If documentation was changed (even for typos), the impact on documentation should be "YES" with a description like "Corrected typos in the I2C driver documentation." * **Testing:** "None" is unacceptable. Even for trivial changes, *some* testing must be performed and documented. At minimum, the PR should state that the code compiles without errors on the developer's build host and, ideally, show that the affected functionality (even documentation) builds and renders correctly. Example: "Build Host: Linux, x86_64, GCC 12. Successfully compiled for sim:nsh config." The PR needs to be more thorough and demonstrate due diligence, even for seemingly minor changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
