nuttxpr commented on PR #15104: URL: https://github.com/apache/nuttx/pull/15104#issuecomment-2530381354
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change, it lacks crucial details. Here's what's missing: * **Summary:** * It doesn't explain *how* the option to disable the path buffer is implemented (e.g., a Kconfig option, a compile-time define, etc.). * It mentions performance improvement, but doesn't quantify or explain it. *How much* improvement is expected? *Why* does it improve performance? * It lacks issue references (if applicable). * **Impact:** * Claiming "N/A" is insufficient. Every change has *some* impact. Even if minimal, it needs to be explicitly stated. For example: * **Impact on user:** YES (Users can configure the path buffer size). * **Impact on build:** Potentially YES (if Kconfig changes are involved, the user might need to reconfigure). * **Impact on compatibility:** Potentially YES (if some applications rely on the existing large `PATH_MAX`, this change could break them if the option is disabled). * Consider the impact on code size (is it reduced?). * **Testing:** * "ci-check" isn't sufficient. While CI is good, the PR should describe *specific tests* performed locally to validate the change. * There are no "before" and "after" logs provided, which are explicitly required. Show how behavior changes with the new option enabled vs. disabled. * The build host and target details are missing. In short, the PR needs to be much more thorough in explaining the change, its impact, and the testing performed to validate it. More specifics and quantifiable data are needed to justify the change and convince reviewers that it is beneficial and safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
