nuttxpr commented on PR #15116:
URL: https://github.com/apache/nuttx/pull/15116#issuecomment-2531451409

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty 
Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   No.  This PR description is insufficient. While it uses the template, it 
provides almost no useful information.  Here's why:
   
   * **Summary:** "Fix some typos" is too vague.  *Which* typos?  Where are 
they located? This needs to be more specific.
   * **Impact:**  "RELEASE" is not a valid answer. It needs to address *each* 
impact question (user, build, hardware, documentation, security, compatibility) 
with either "NO" or "YES (and an explanation)."  Marking "RELEASE" suggests 
this is a release-blocking issue, but doesn't explain *why*.  If it's truly 
release-blocking, the impact must be clearly articulated.  For typos, most of 
these will likely be "NO," but documentation might be "YES (updated 
documentation to correct typos)."
   * **Testing:** "CI" is also insufficient. While CI testing is important,  
the PR description *must* include local testing results.  "CI" alone doesn't 
prove the submitter tested the changes locally. The "Testing logs before 
change" and "Testing logs after change" sections must be filled with actual 
logs demonstrating the problem before the fix and the successful operation 
after the fix.  Even for minor typos, some evidence of verification is 
necessary.
   
   
   In short, the author needs to provide significantly more detail for this PR 
to be considered acceptable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to