anchao commented on code in PR #15138:
URL: https://github.com/apache/nuttx/pull/15138#discussion_r1879840048
##########
sched/clock/clock_adjtime.c:
##########
@@ -108,7 +109,7 @@ static int adjtime_start(long long adjust_usec)
ppb = -ppb_limit;
}
- flags = enter_critical_section();
+ flags = spin_lock_irqsave(&g_adjtime_lock);
Review Comment:
What I mean is, you're not entirely sure how each lower half will implement
these interfaces, right? If the up_xxx API has access to global variables,
local spinlock may not guarantee that the underlying implementation has
exclusive access to variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
