xiaoxiang781216 commented on code in PR #15150:
URL: https://github.com/apache/nuttx/pull/15150#discussion_r1881517668
##########
boards/arm/stm32h7/linum-stm32h753bi/configs/littlefs/defconfig:
##########
@@ -30,7 +30,7 @@ CONFIG_EXAMPLES_ALARM=y
CONFIG_EXAMPLES_ALARM_STACKSIZE=2048
CONFIG_FS_LITTLEFS=y
CONFIG_FS_LITTLEFS_MULTI_VERSION=y
-CONFIG_FS_LITTLEFS_VERSION="v2.9.3"
+CONFIG_FS_LITTLEFS_VERSION="v2.10.0"
Review Comment:
should we just change one to improve the ci coverage?
##########
fs/littlefs/CMakeLists.txt:
##########
@@ -51,17 +51,18 @@ if(CONFIG_FS_LITTLEFS)
target_compile_definitions(
fs
- PRIVATE
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_TRACE=finfo>
-
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_DEBUG=finfo>
-
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_WARN=fwarn>
-
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_ERROR=ferr>
-
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_ASSERT=DEBUGASSERT>
-
$<$<NOT:$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>>:-DLFS_CONFIG=${CMAKE_CURRENT_LIST_DIR}/lfs_vfs.h>
-
$<$<BOOL:${CONFIG_FS_LITTLEFS_HAS_LFS_DEFINES}>:-DLFS_DEFINES=${CMAKE_CURRENT_LIST_DIR}/lfs_nuttx_defines.h>
- -DLFS_NAME_MAX=${CONFIG_FS_LITTLEFS_NAME_MAX}
- -DLFS_FILE_MAX=${CONFIG_FS_LITTLEFS_FILE_MAX}
- -DLFS_ATTR_MAX=${CONFIG_FS_LITTLEFS_ATTR_MAX}
- $<$<BOOL:${CONFIG_FS_LITTLEFS_MULTI_VERSION}>:-DLFS_MULTIVERSION>)
+ PRIVATE
Review Comment:
why not done in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
