yamt commented on code in PR #14898:
URL: https://github.com/apache/nuttx/pull/14898#discussion_r1883383329
##########
fs/vfs/fs_uio.c:
##########
@@ -51,18 +51,69 @@ ssize_t uio_total_len(FAR const struct uio *uio)
{
const struct iovec *iov = uio->uio_iov;
int iovcnt = uio->uio_iovcnt;
+ size_t offset_in_iov = uio->uio_offset_in_iov;
size_t len = 0;
Review Comment:
it can be ssize_t, sure.
otoh, writing code with signed arithmetic uses my brain cycles more.
and from my experience, sometimes compilers produce less efficient machine
code.
let me think a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
