nuttxpr commented on PR #15180: URL: https://github.com/apache/nuttx/pull/15180#issuecomment-2541098781
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary (albeit a very brief one), it lacks crucial details. Here's what's missing: * **Summary:** "remove fl_crefs" is insufficient. *Why* is this removal necessary? What problem does it solve? What function did `fl_crefs` serve? How does the removal work (what code was changed)? Are there related issues? * **Impact:** Simply stating "flist" is not enough. Address *all* impact points explicitly (User, Build, Hardware, Documentation, Security, Compatibility). Even if the answer is "NO", state it explicitly. For example: "Impact on user: NO". If there *is* an impact, describe it. * **Testing:** "ci" is inadequate. Provide details about your local testing environment (OS, CPU, compiler) and the target platform (architecture, board, configuration). Include *actual* testing logs demonstrating the behavior before and after the change. Simply relying on CI testing is not sufficient for a PR review. The PR needs substantial revision to provide the necessary context and evidence that the change is correct and well-considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
