nuttxpr commented on PR #15212: URL: https://github.com/apache/nuttx/pull/15212#issuecomment-2547068996
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to **mostly** meet the NuttX requirements but is missing some key information. Here's a breakdown: * **Summary:** While it mentions SPDX and SBOM generation, it lacks specifics. *What* functional part of the code is changed? *How* does the change work (e.g., what files were modified, what new functions were added)? The linked PRs are helpful, but the summary should stand on its own. * **Impact:** Stating "RELEASE" is insufficient. Go through each impact point (user, build, hardware, documentation, security, compatibility) and answer NO/YES with a brief explanation. Even if the answer is NO, explicitly stating it is helpful for reviewers. A RELEASE impact usually implies significant changes, so more detail is essential. * **Testing:** "CI" is also insufficient. While CI testing is important, it needs to be supplemented with details about *what* was tested. List the specific build hosts and targets used for testing. The "Testing logs before change" and "Testing logs after change" sections are empty. Provide concrete examples of the output before and after the changes, demonstrating that the change has the intended effect. Ideally, these logs would show the SPDX identifiers being used/generated. **In short, the PR description needs to be more comprehensive and specific to allow reviewers to understand the changes and their impact fully.** Provide more detail in the summary, explicitly address each impact point, and include concrete testing logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
