nuttxpr commented on PR #2892: URL: https://github.com/apache/nuttx-apps/pull/2892#issuecomment-2547458753
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change and testing information, it lacks crucial details. Here's what's missing: * **Summary:** * **Why is this change necessary?** What problem does it solve or what improvement does it provide? Just stating "add support for disable sigmask from ps command" isn't enough. Explain the rationale. Is the sigmask output irrelevant in some contexts? Is it causing formatting issues? Is it too verbose? * **What functional part of the code is being changed?** Be specific. Mention the file(s) modified (e.g., `nshlib/nsh_ps.c`). * **How does the change exactly work?** What code was added or removed to achieve this? Did you introduce a new option to the `ps` command? How is it controlled? * **Impact:** Filling in "N/A" is almost never correct. Consider each point: * **Is new feature added?** YES. Explain the new feature: the ability to suppress sigmask output in the `ps` command. * **Impact on user?** YES. The output of the `ps` command can now be different. Describe how a user might enable/disable this new behavior. * **Others:** Even if there's no impact, explicitly state "NO" for each item and briefly justify it (e.g., "Impact on build: NO, no changes to Makefiles or build scripts"). * **Testing:** * **Build Host(s):** Specify details about your build host. * **Target(s):** Be more specific. e.g., `sim:nsh` or `qemu-x86_64:nsh`. * **Testing logs before change:** The logs provided only show the output of `ps`. Show how you triggered this output before the change. Ideally, also include the commands used to build NuttX. * **Testing logs after change:** Same as above. Show the commands leading up to the `ps` output, demonstrating how the new feature is used (how is the sigmask disabling triggered?). Also show build commands. By providing this missing information, the PR will be much clearer, easier to review, and more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
