nuttxpr commented on PR #15237: URL: https://github.com/apache/nuttx/pull/15237#issuecomment-2547852962
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not adequately meet the NuttX requirements. While it provides some information, it lacks crucial details and context. Here's why: * **Summary:** Saying "use atomic_t to store bd_bifup" is insufficient. *Why* is this change necessary? What problem does it solve? What is `bd_bifup` and what functional part of the Bluetooth code is affected? How does using `atomic_t` change its behavior? Issue/PR references are missing. * **Impact:** Simply stating "bluetooth" is far too vague. Does this affect all Bluetooth functionality? Specific details are required for *all* impact categories (user, build, hardware, documentation, security, compatibility). Even if the answer is "NO," it should be explicitly stated. * **Testing:** "ci" is not acceptable. The request explicitly asks for: * Details about the build host and target environments. * "Testing logs before change" and "Testing logs after change" – actual log output demonstrating the issue being fixed and the successful result after the change. Just saying "ci" provides no evidence that the change works as intended. The PR needs to be significantly revised to provide the required level of detail and evidence before it can be properly reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
