pussuw commented on code in PR #15081: URL: https://github.com/apache/nuttx/pull/15081#discussion_r1888583058
########## arch/risc-v/include/arch.h: ########## @@ -120,6 +245,84 @@ extern "C" #define EXTERN extern #endif +#ifndef __ASSEMBLY__ + +/**************************************************************************** Review Comment: Then again, holding the return value of either outside of a critical section is not valid either ? But it is good to patch them regardless. I don't think these functions are called from anywhere though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
