nuttxpr commented on PR #15256: URL: https://github.com/apache/nuttx/pull/15256#issuecomment-2550644199
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing with CI, it lacks crucial details. Here's what's missing: * **Summary:** Needs more detail. *How* does `modifyreg16` work with the small lock? What was the previous locking mechanism (the "big lock")? Why is this change beneficial (performance, deadlock avoidance, etc.)? Issue references are missing. * **Impact:** The impact section is severely lacking. All answers are essentially "NO" by omission. At a minimum, the impact on hardware and compatibility needs to be addressed. Does this change affect all architectures? Is it backwards compatible? Even if the answer is "NO", it needs to be explicitly stated. * **Testing:** CI passing is not sufficient. "Testing logs before change" and "Testing logs after change" sections are empty. What was tested? What were the results? Provide specific examples showing the improvement or demonstrating the fix. Include the build host and target details. Without this additional information, the PR cannot be properly reviewed and evaluated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
