nuttxpr commented on PR #15257: URL: https://github.com/apache/nuttx/pull/15257#issuecomment-2550743075
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details and depth in several areas. Here's a breakdown of the missing information: * **Summary:** While it mentions using a small lock, it doesn't explain *why* this is necessary. What problem does it solve? What are the benefits? It also needs to specify *how* the change works. What big lock is being replaced? What small lock is being used? What code is modified? Finally, it needs to link related NuttX issues if applicable. * **Impact:** The PR only mentions `cxd32_uart`, which is presumably the affected driver. However, it needs to explicitly answer all the impact questions (user, build, hardware, documentation, security, compatibility) with "YES" or "NO" and provide descriptions where necessary. Just stating `cxd32_uart` doesn't tell us anything about the impact. Does this change the driver's API? Does it require board configuration changes? Does it affect other drivers? * **Testing:** Simply stating "ci" is insufficient. The PR needs to specify the *actual* build hosts and targets used for testing. It also needs to provide *meaningful* testing logs *before* and *after* the change, demonstrating the issue the change addresses and verifying that the change fixes the issue. "ci" implies Continuous Integration, but the actual test environments and results must still be reported in the PR. In short, the PR needs to be significantly more detailed and explicit to meet the NuttX requirements. It should clearly explain the motivation, implementation, and impact of the change, and provide verifiable testing results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
