JianyuWang0623 opened a new pull request, #2903:
URL: https://github.com/apache/nuttx-apps/pull/2903

   ## Summary
   1. [nshlib/nsh_parse: Closing fds opened for redirection if 
necessary](https://github.com/apache/nuttx-apps/commit/ade300b1b9b28d295f4684f17802e5a59d874c96)
   ```
   CID 1612743: (https://github.com/apache/nuttx-apps/pull/1 of 1): Resource 
leak (RESOURCE_LEAK)
     12. leaked_handle: The handle variable fd_out goes out of scope and leaks 
the handle.
   ```
   3. [nshlib/nsh_parse: Removing unnecessary value assigning about 
redirection](https://github.com/apache/nuttx-apps/commit/6a50d76f1752e29563a680425384b239e0b74ab1)
   ```
   CID 1612757: (https://github.com/apache/nuttx-apps/pull/1 of 1): UNUSED_VALUE
     assigned_value: The value -1 is assigned to param.fd_in here, but the 
stored value is overwritten before it can be used.
   ```
   ## Impact
   nshlib/nsh_parse
   
   ## Testing
   1. Selftesting with cmd return value and pipeline PASSED
   2. NuttX CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to