jlaitine commented on code in PR #15145:
URL: https://github.com/apache/nuttx/pull/15145#discussion_r1889987197


##########
drivers/bch/bchdev_driver.c:
##########
@@ -459,6 +459,13 @@ static int bch_ioctl(FAR struct file *filep, int cmd, 
unsigned long arg)
           if (bchinode->u.i_bops->ioctl != NULL)
             {
               ret = bchinode->u.i_bops->ioctl(bchinode, cmd, arg);
+
+              /* Drivers may not support command BIOC_FLUSH */
+
+              if (ret == -ENOTTY && cmd == BIOC_FLUSH)

Review Comment:
   Is the intent here that the IOCTL is not passed to the driver, if 
bchlib_flushsector returns error?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to