xiaoxiang781216 commented on code in PR #15255:
URL: https://github.com/apache/nuttx/pull/15255#discussion_r1890144127
##########
arch/arm/src/at32/at32_serial.c:
##########
@@ -2618,11 +2628,20 @@ static void up_txint(struct uart_dev_s *dev, bool
enable)
{
/* Disable the TX interrupt */
- up_restoreusartint(priv, priv->ie & ~USART_CTRL1_TDBEIEN);
Review Comment:
why change
##########
arch/arm/src/at32/at32_serial.c:
##########
@@ -2599,12 +2610,11 @@ static void up_txint(struct uart_dev_s *dev, bool
enable)
# ifdef CONFIG_AT32_SERIALBRK_BSDCOMPAT
if (priv->ie & USART_CR1_IE_BREAK_INPROGRESS)
{
- leave_critical_section(flags);
return;
}
# endif
- up_restoreusartint(priv, ie);
Review Comment:
why change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
