anchao commented on code in PR #15299:
URL: https://github.com/apache/nuttx/pull/15299#discussion_r1893664442
##########
arch/arm/src/armv7-a/arm_gicv2.c:
##########
@@ -72,11 +72,7 @@ static volatile cpu_set_t g_gic_init_done;
#if defined(CONFIG_SMP) && CONFIG_SMP_NCPUS > 1
static void arm_gic_init_done(void)
{
- irqstate_t flags;
-
- flags = spin_lock_irqsave(NULL);
- CPU_SET(this_cpu(), &g_gic_init_done);
- spin_unlock_irqrestore(NULL, flags);
+ atomic_fetch_or(&g_gic_init_done, 1 << this_cpu());
Review Comment:
replace line 84 to atomic also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
