Javinator9889 commented on code in PR #15320:
URL: https://github.com/apache/nuttx/pull/15320#discussion_r1896765336


##########
libs/libc/stdio/lib_libvsprintf.c:
##########
@@ -911,6 +915,11 @@ static int vsprintf_internal(FAR struct lib_outstream_s 
*stream,
           size = 1;
           goto str_lpad;
 
+        case 'm': /* Print error message (%m) */
+          pnt = strerror(saved_errno);
+          size = strlen(pnt); /* Adjusting the size is not supported by %m */
+          goto str_lpad;
+

Review Comment:
   I'd say @patacongo to revert it for the moment. I made the change not 
expecting to potentially break builds but to add support to a POSIX-compliant 
modifier. Theoretically, this runs on user space, so breaking kernel space was 
never an option in my mind.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to