yamt commented on code in PR #15323:
URL: https://github.com/apache/nuttx/pull/15323#discussion_r1896997735
##########
drivers/serial/uart_pl011.c:
##########
@@ -748,6 +748,7 @@ static void pl011_txint(FAR struct uart_dev_s *dev, bool
enable)
if (enable)
{
pl011_irq_tx_enable(sport);
+ spin_unlock_irqrestore(&sport->lock, flags);
/* Fake a TX interrupt here by just calling uart_xmitchars() with
* interrupts disabled (note this may recurse).
Review Comment:
do you mean this comment ("with interrupts disabled") is referring to the
critical section?
well, it makes sense, but quite confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
